From: Andrei Rybak <rybak.a.v@gmail.com>
Date: Mon, 09 Jul 2018 07:59:31 GMT
Subject: Re: [PATCH v4 1/4] rebase: start implementing it as a builtin
Message-ID: <857b04d8-37b4-596f-6f3e-45b6e2a59442@gmail.com>
In-Reply-To: <20180708180104.17921-2-predatoramigo@gmail.com>

On 2018-07-08 20:01, Pratik Karki wrote:
> +
> +static int use_builtin_rebase(void)
> +{
> +	struct child_process cp = CHILD_PROCESS_INIT;
> +	struct strbuf out = STRBUF_INIT;
> +	int ret;
> +
> +	argv_array_pushl(&cp.args,
> +			 "config", "--bool", "rebase.usebuiltin", NULL);
> +	cp.git_cmd = 1;
> +	if (capture_command(&cp, &out, 6))
> +		return 0;

Does strbuf out leak on return here?

> +
> +	strbuf_trim(&out);
> +	ret = !strcmp("true", out.buf);
> +	strbuf_release(&out);
> +	return ret;
> +}