From: David Turner <david.turner@twosigma.com>
Date: Mon, 19 Dec 2016 16:03:09 GMT
Subject: RE: [PATCH] pack-objects: don't warn about bitmaps on incremental pack
Message-ID: <84da83e80fff40e3b7de43d2a11d440d@exmbdft7.ad.twosigma.com>
In-Reply-To: <20161217040426.7qeixbihiou5mbsl@sigill.intra.peff.net>

> diff --git a/builtin/gc.c b/builtin/gc.c index 069950d0b4..d3c978c765
> 100644
> --- a/builtin/gc.c
> +++ b/builtin/gc.c
> @@ -191,6 +191,11 @@ static void add_repack_all_option(void)
>  	}
>  }
> 
> +static void add_repack_incremental_option(void)
> +{
> +	argv_array_push(&repack, "--no-write-bitmap-index"); }
> +
>  static int need_to_gc(void)
>  {
>  	/*
> @@ -208,7 +213,9 @@ static int need_to_gc(void)
>  	 */
>  	if (too_many_packs())
>  		add_repack_all_option();
> -	else if (!too_many_loose_objects())
> +	else if (too_many_loose_objects())
> +		add_repack_incremental_option();
> +	else
>  		return 0;
> 
>  	if (run_hook_le(NULL, "pre-auto-gc", NULL))

Sure, that's fine.