From: Wincent Colaiuta <win@wincent.com>
Date: Fri, 16 Nov 2007 18:02:54 GMT
Subject: Re: [PATCH] Fix t7004 which fails with retarded sed
Message-ID: <83DEF29B-4E72-4913-A77E-8C00D69B48E4@wincent.com>
In-Reply-To: <1195233971-12288-1-git-send-email-mh@glandium.org>

El 16/11/2007, a las 18:26, Mike Hommey escribió:

> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> index 096fe33..3813f23 100755
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -1007,7 +1007,9 @@ test_expect_failure \
> test_expect_success \
> 	'message in editor has initial comment' '
> 	GIT_EDITOR=cat git tag -a initial-comment > actual || true &&
> -	test $(sed -n "/^\(#\|\$\)/p" actual | wc -l) -gt 0
> +	grep -e "^$" actual > /dev/null 2>&1 &&
> +	grep -e "^#" actual > /dev/null 2>&1 &&
> +	! grep -e "^[^#]" actual > /dev/null 2>&1
> '

Yep, that works here, and is a much more rigourous test than what we  
had.

Cheers,
Wincent