From: Derrick Stolee Date: Fri, 22 Nov 2019 01:57:07 GMT Subject: Re: [PATCH 01/11] fsmonitor: disable in a bare repo Message-ID: <837dca23-1681-2111-efaf-e38d603ea3f6@gmail.com> In-Reply-To: <20191121231818.GA22688@generichostname> On 11/21/2019 6:18 PM, Denton Liu wrote: > Hi Stolee, > > On Thu, Nov 21, 2019 at 10:20:16PM +0000, Derrick Stolee via GitGitGadget wrote: >> From: Derrick Stolee >> >> t0003-attributes.sh > > Patches 1 and 2 have this line in the commit message. I assume it's a > typo? > > Also, for the patches with empty commit message bodies, it would be nice > if they were filled in with detail for _why_ the change is being made. > For example, in this patch, a future reader might wonder why having > fsmonitor enabled in a bare repo causes problems. Thanks for pointing that out. I forgot to clean up these messages, and what I left in them right now is sometimes just the first test script that was failing without the change. Thanks, -Stolee