From: Yann Droneaud Date: Fri, 22 Mar 2013 14:56:15 GMT Subject: Re: [PATCH] t7600: merge tag shoud create a merge commit Message-ID: <831c87ad325075b6049ef52c24477da2@meuh.org> In-Reply-To: <7vr4j78p8a.fsf@alter.siamese.dyndns.org> Le 22.03.2013 15:48, Junio C Hamano a écrit : >> >> It's not in final shape: the line >> >> EDITOR=false test_must_fail git merge signed > > Because test_must_fail is a shell function, single-shot environment > assignment like this should not be used. It's used throughout the test. The test 'merge --no-edit tag should skip editor' is using it. Before posting my half useful test, I used "EDITOR=false test_must_fail set" in --verbose mode to find if EDITOR was correctly defined passed test_must_fail, and it was. So it's still not clear why it's failing at failing. And it's making me angry. Regards. -- Yann Droneaud OPTEYA