From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Mon, 13 Jul 2026 20:15:28 GMT
Subject: Re: cygwin v2.55.0 test failures
Message-ID: <82ef71fc-8099-48dd-b841-87188bd39fa0@ramsayjones.plus.com>
In-Reply-To: <20260712200426.GA11328@tb-raspi4>



On 12/07/2026 9:04 pm, Torsten Bögershausen wrote:
> On Fri, Jul 10, 2026 at 07:32:23PM +0100, Ramsay Jones wrote:
[snip]
>> [I also had a note-to-self about 'mixed / and \ urls' in the config file
>> which is exposed by these same tests. So, another patch may be needed?]
> Not sure if I follow. cygwin allows mixed / and \ . What should be patched ? 

Yes, maybe nothing needs patching - it was a note-to-self to check that the
mixed urls don't cause any issues and, maybe, normalize the urls before
writing them to the config.

>>
>> Anyway, something to think about. Hmm, I suspect it would be best to just
>> tidy up this patch first. ;)
>>
>> Just FYI. Thanks!
>>
>> ATB,
>> Ramsay Jones
>> diff --git a/connect.c b/connect.c
>> index 47e39d2a73..6f5715e938 100644
>> --- a/connect.c
>> +++ b/connect.c
>> @@ -1088,10 +1088,12 @@ static enum url_scheme parse_connect_url(const char *url_orig, char **ret_host,
>>  
>>  	if (scheme == URL_SCHEME_LOCAL)
>>  		path = end;
>> +#ifdef DUMMY
>>  	else if (scheme == URL_SCHEME_FILE && *host != '/' &&
>>  		 !has_dos_drive_prefix(host) &&
>>  		 offset_1st_component(host - 2) > 1)
>>  		path = host - 2; /* include the leading "//" */
>> +#endif
> 
> This very lines come from
> 
> commit ebb8d2c90fb0840a0803935804e37e2205505f23
>   mingw: support UNC in git clone file://server/share/repo
> 
> ...and I can not see a reason to remove it.

Heh, I just read a few references [1][2][3] about file URIs to refresh my
memory (I read the RFCs many many moons ago ... and they seem to have
changed in the meantime? At least I don't remember it said that! :) ).

I seem to have misremembered the 'number of slashes' after the 'file:'
prefix as three or four, not two (specifically with a windows UNC or
absolute path). However, I was clearly wrong!

[The 'non-standard' rules on win32 are wild - git clearly doesn't support
all the edge cases].

OK, so I probably need to look at the two failing tests again - maybe I
need to mark them with !CYGWIN.

Anyway, more work to do! ;)

ATB,
Ramsay Jones

[1] https://en.wikipedia.org/wiki/File_URI_scheme
[2] https://datatracker.ietf.org/doc/rfc8089/
[3] https://learn.microsoft.com/en-us/archive/blogs/ie/file-uris-in-windows