From: Derrick Stolee Date: Mon, 17 Jun 2019 15:07:34 GMT Subject: Re: [PATCH] commit-graph: normalize commit-graph filenames Message-ID: <8251cbca-cbac-ef7f-57fa-a3671fbd6704@gmail.com> In-Reply-To: <20190617150207.16849-1-dstolee@microsoft.com> On 6/17/2019 11:02 AM, Derrick Stolee wrote: > - strbuf_setlen(&path, dirnamelen); > - strbuf_addstr(&path, de->d_name); > + char *filename = get_split_graph_filename(path.buf, de->d_name); Please ignore this patch for now, as this line is incredibly stupid and breaks the tests that I somehow forgot to run before submitting. Thanks, -Stolee