From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Thu, 10 Feb 2022 01:18:07 GMT
Subject: Re: [PATCH] t/t0015-hash.sh: removed unnecessary '\' at line end
Message-ID: <81e8a217-356d-65cd-3a89-f20ef9c1a5d7@gmail.com>
In-Reply-To: <20220208092339.651761-2-jaydeepjd.8914@gmail.com>

On 08/02/22 16.23, Jaydeep P Das wrote:
> From: Jaydeep Das <jaydeepjd.8914@gmail.com>
> 
> The `|` at line end already imples that the statement is not over.
> So a `\` after that is redundant.
> 
> Signed-off-by: Jaydeep P Das <jaydeepjd.8914@gmail.com>
> ---
>   t/t0015-hash.sh | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/t/t0015-hash.sh b/t/t0015-hash.sh
> index 291e9061f3..086822fc45 100755
> --- a/t/t0015-hash.sh
> +++ b/t/t0015-hash.sh
> @@ -15,7 +15,7 @@ test_expect_success 'test basic SHA-1 hash values' '
>   	grep c12252ceda8be8994d5fa0290a47231c1d16aae3 actual &&
>   	printf "abcdefghijklmnopqrstuvwxyz" | test-tool sha1 >actual &&
>   	grep 32d10c7b8cf96570ca04ce37f2a19d84240d3a89 actual &&
> -	perl -e "$| = 1; print q{aaaaaaaaaa} for 1..100000;" | \
> +	perl -e "$| = 1; print q{aaaaaaaaaa} for 1..100000;" |
>   		test-tool sha1 >actual &&
>   	grep 34aa973cd4c4daa4f61eeb2bdbad27316534016f actual &&
>   	printf "blob 0\0" | test-tool sha1 >actual &&
> @@ -38,10 +38,10 @@ test_expect_success 'test basic SHA-256 hash values' '
>   	printf "abcdefghijklmnopqrstuvwxyz" | test-tool sha256 >actual &&
>   	grep 71c480df93d6ae2f1efad1447c66c9525e316218cf51fc8d9ed832f2daf18b73 actual &&
>   	# Try to exercise the chunking code by turning autoflush on.
> -	perl -e "$| = 1; print q{aaaaaaaaaa} for 1..100000;" | \
> +	perl -e "$| = 1; print q{aaaaaaaaaa} for 1..100000;" |
>   		test-tool sha256 >actual &&
>   	grep cdc76e5c9914fb9281a1c7e284d73e67f1809a48a497200e046d39ccc7112cd0 actual &&
> -	perl -e "$| = 1; print q{abcdefghijklmnopqrstuvwxyz} for 1..100000;" | \
> +	perl -e "$| = 1; print q{abcdefghijklmnopqrstuvwxyz} for 1..100000;" |
>   		test-tool sha256 >actual &&
>   	grep e406ba321ca712ad35a698bf0af8d61fc4dc40eca6bdcea4697962724ccbde35 actual &&
>   	printf "blob 0\0" | test-tool sha256 >actual &&

Looks OK.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara