From: Alex Riesen Date: Tue, 04 Aug 2009 21:05:54 GMT Subject: Re: Please make git-am handle \r\n-damaged patches Message-ID: <81b0412b0908041405u1da859f2lf23d6ba25e3bef1f@mail.gmail.com> In-Reply-To: <40aa078e0908041359p79b111eo2f389dde25bb0876@mail.gmail.com> On Tue, Aug 4, 2009 at 22:59, Erik Faye-Lund wrote: > On Tue, Aug 4, 2009 at 8:46 AM, Junio C Hamano wrote: >> I thought about this approach, but it made me worried about a case where >> an otherwise sane piece of e-mail has \r at the end of one line as the >> real payload. But as long as we are talking about a text e-mail (and we >> are talking about mailsplit here and a binary payload with a CTE applied >> counts as text), I think we can safely use an approach like this. > > RFC 2822, section 2.3 explicitly states that a CR should not occur > without a LF (and vice versa, but the e-mail client might convert CRLF > to LF when saving to file), so I think this should be safe. You missed this line in original posters e-mail: "In a serious case of craniorectal immersion..." We are not safe from that and alike.