From: Alex Riesen <raa.lkml@gmail.com>
Date: Sun, 14 Jun 2009 22:03:27 GMT
Subject: Re: [PATCH] use xstrdup, not strdup in ll-merge.c
Message-ID: <81b0412b0906141503v14484d9fyea56198910305bfc@mail.gmail.com>
In-Reply-To: <87bpoqoavp.fsf@meyering.net>

2009/6/14 Jim Meyering <jim@meyering.net>:
> @@ -231,7 +231,7 @@ static int read_merge_config(const char *var, const char *value, void *cb)
>
>        if (!strcmp(var, "merge.default")) {
>                if (value)
> -                       default_ll_merge = strdup(value);
> +                       default_ll_merge = xstrdup(value);

read_merge_config has a failure mode (where it returns -1), why not use it?