From: Alex Riesen <raa.lkml@gmail.com>
Date: Fri, 15 May 2009 15:51:09 GMT
Subject: Re: git-tag bug? confusing git fast-export with double tag objects
Message-ID: <81b0412b0905150851q232b3f6s95df89e72d4dc381@mail.gmail.com>
In-Reply-To: <4A0D8211.5010806@viscovery.net>

2009/5/15 Johannes Sixt <j.sixt@viscovery.net>:
> Jakub Narebski schrieb:
>> "Matthias Andree" <matthias.andree@gmx.de> writes:
>>>      commit <-- signed-by-- NIL (removed) <--signed-by-- tag1.
>>
>> THIS IS A FEATURE, NOT A BUG.
>
> Please stop it. Everone agrees about this.
>
> Matthias only wants a patch like below. Matthias, if you are serious about
> it, please pick this up and turn it into a proper submission. I don't care
> enough.
>
...
> +       if ((tag_object = (struct tag *)parse_object(object)) &&
> +           tag_object->object.type == OBJ_TAG &&
> +           tag_object->tag &&
> +           !strcmp(tag_object->tag, tag)) {
> +               error("A tag cannot tag itself. If you meant to tag the commit");

If it ever turned into submission, I'll always patch this out. It is stupid.