From: Alex Riesen <raa.lkml@gmail.com>
Date: Wed, 18 Mar 2009 07:22:24 GMT
Subject: Re: [PATCH] Define a version of lstat(2) specially for copy operation
Message-ID: <81b0412b0903180022w4b95106ds54a16a835b53c1d@mail.gmail.com>
In-Reply-To: <20090317213820.GC13458@blimp.localdomain>

2009/3/17 Alex Riesen <raa.lkml@gmail.com>:
>> hooks copied from templates?  I think we could pass mode 0 to copy_files()
>> and have the function special case it (and allow a platform specific
>> copy_files() implemented by Cygwin).  lstat() in the copy_templates_1()
>> codepath is primarily done to see if we need to descend into a directory
>> or symlink() and our use of st.st_mode to pass to copy_files() is a no
>> cost side effect on platforms with x-bit support.
>
> And I don't think that the platform broken in so many ways deserves
> that kind of treatment. Maybe this patch is enough. Will test it
> tomorrow, when I get to mine so much hated Windows system.
>

Ok, I just tested it and it works. Junio, this patch can replace the previous
change which disabled the test.