From: Alex Riesen Date: Thu, 19 Feb 2009 08:24:01 GMT Subject: Re: [PATCH] check_updates(): effective removal of cache entries marked CE_REMOVE Message-ID: <81b0412b0902190024t3fc7ab20r9a23c72270ac1033@mail.gmail.com> In-Reply-To: <1234995483-933-1-git-send-email-barvik@broadpark.no> 2009/2/18 Kjetil Barvik : > If we can trust the numbers from oprofile in this case, we saved > approximately ((7710 - 46) * 20000) / (2 * 1000 * 1000 * 1000) = 0.077 > seconds CPU time with this fix for this particular test. And notice > that now the CPU did only 46 / 15 = 3.1 cycles/instruction. ... > diff --git a/unpack-trees.c b/unpack-trees.c > index e3c3fa1..273b5da 100644 > --- a/unpack-trees.c > +++ b/unpack-trees.c > @@ -93,11 +93,9 @@ static int check_updates(struct unpack_trees_options *o) > display_progress(progress, ++cnt); > if (o->update) > unlink_entry(ce); > - remove_index_entry_at(&o->result, i); > - i--; > - continue; > } > } > + remove_marked_cache_entries(&o->result); > remove_scheduled_dirs(); > What commit is this change based on? It does not apply to any of Junio's master, next, or pu...