From: Alex Riesen <raa.lkml@gmail.com>
Date: Mon, 13 Oct 2008 06:18:01 GMT
Subject: Re: [PATCH v2] correct verify_path for Windows
Message-ID: <81b0412b0810122318h15e8f5bue9b8ee8da71a7c33@mail.gmail.com>
In-Reply-To: <48F2E410.2080504@viscovery.net>

2008/10/13 Johannes Sixt <j.sixt@viscovery.net>:
> Alex Riesen schrieb:
>> I looked at the callers (briefly). Performance could be a problem: add
>> and checkout can work with real big file lists and long pathnames.
>> So ok, than. It is critical.
>
> You are kidding, aren't you? What you win by a few CPU instructions here
> is dwarfed by the time that the stat() implementation requires. Dmitry,
> please use the more readable tolower().

It is called for every element in a path, not just for every filename.
And maybe it is dwarfed, but they both are part of the same operation.
And this code makes it more CPU intensive.