From: Alex Riesen Date: Fri, 10 Oct 2008 06:52:40 GMT Subject: Re: [PATCH] fix pread()'s short read in index-pack Message-ID: <81b0412b0810092352n2a9cb5d2m6a0550354af0b397@mail.gmail.com> In-Reply-To: 2008/10/10 Nicolas Pitre : > > Since v1.6.0.2~13^2~ the completion of a thin pack uses sha1write() for > its ability to compute a SHA1 on the written data. This also provides > data buffering which, along with commit 92392b4a45, will confuse pread() > whenever an appended object is 1) freed due to memory pressure because > of the depth-first delta processing, and 2) needed again because it has > many delta children, and 3) its data is still buffered by sha1write(). So I seem to have had luck not doing gc in either of source or target repos (I usually repack, than fetch. Especially this one repo, it's very active). BTW, I run into complications trying to test the fix on Shawn's master: conflicts, and my trivial resolution wasn't good enough. Aside from that, I confirm the case fixed.