From: Alex Riesen <raa.lkml@gmail.com>
Date: Sat, 09 Jun 2007 21:52:29 GMT
Subject: Re: [PATCH 16/21] Introduce optional "keywords" on tag objects
Message-ID: <81b0412b0706091452q2957540dy95fbf13ebd89ca1f@mail.gmail.com>
In-Reply-To: <200706090219.37289.johan@herland.net>

On 6/9/07, Johan Herland <johan@herland.net> wrote:
> This patch introduces a new optional header line to the tag object, called
> "keywords". The "keywords" line may contain a comma-separated list of
> custom keywords associated with the tag object.

What is the character set for the keywords?

> +                       for (i = 0; i < keywords_len; ++i) {
> +                               unsigned char c = keywords_line[i];
> +                               if (c == ',' && keywords_line[i + 1] == ',')
> +                                       /* consecutive commas */
> +                                       return error("Tag object (@ char "
> +                                               PD_FMT "): Found empty keyword",
> +                                               keywords_line + i - data);
> +                               if (c > ' ' && c != 0x7f)
> +                                       continue;

And what is so special about 0x7f?


> +               if (keywords_len) { /* optional keywords string was given */
> +                       item->keywords = xmalloc(keywords_len + 1);

Who frees the keywords and what's wrong with strndup?