From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 10 May 2007 11:39:36 GMT
Subject: Re: [PATCHv2] connect: display connection progress
Message-ID: <81b0412b0705100439j4e6b072bk1ba19a4f971e5d0c@mail.gmail.com>
In-Reply-To: <20070510095156.GC13655@mellanox.co.il>

On 5/10/07, Michael S. Tsirkin <mst@dev.mellanox.co.il> wrote:
> -static int git_tcp_connect_sock(char *host)
> +static int git_tcp_connect_sock(char *host, int flags)

There is only one bit of flags ever used. What are the others for?
Why use negative logic?
What was wrong with plain "int verbose"?
What addresses were tried by connect?