From: Alex Riesen Date: Wed, 14 Mar 2007 12:26:33 GMT Subject: Re: [PATCH] Allow git-diff exit with codes similar to diff(1) Message-ID: <81b0412b0703140526p454ee85fk74dcd76fb684217c@mail.gmail.com> In-Reply-To: On 3/14/07, Johannes Schindelin wrote: > > But we have isatty in setup_pager, so this works properly. > > The problem is test cases. I think that we pipe the output of the test > case _anyway_, so the isatty() call is helping us there. > > If we did not (this applies to test cases _outside_ of Git, too), then a > simple > > git diff bla || exit > > would not work as expected. Even worse, as long as it is piped somewhere, > even cat, it works. But once you no longer pipe it (to get the nice pager, > for example), it stops working. We have "PAGER=cat" in test-lib.sh which just disables pager, so gits tests do not have the problem (maybe it was disabled just because of this?). And if someone has own tests _with_ pager active the one better be aware of what the one doing.