From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 18 Jan 2007 15:52:40 GMT
Subject: Re: [PATCH/POLL] git-format-patch: the default suffix is now .patch, not .txt
Message-ID: <81b0412b0701180752x1664f661o17ce78a7024590f3@mail.gmail.com>
In-Reply-To: <20070118152620.GB15428@spearce.org>

On 1/18/07, Shawn O. Pearce <spearce@spearce.org> wrote:
> > don't think so. I _would_ cry seeing how fork(2) gets ported to Windows,
> > and you will, probably... after seeing how it is done in cygwin.
>
> AFAIK there's not a strong reason to keep fork() in Git.
>
> Currently anytime we fork a process its to perform a small amount
> of file descriptor redirection and then immediately exec some other
> executable, or a hook script.  In other words we probably could
> convert all current uses of fork to something like in run-command.c,
> which a Windows port could then easily replace using CreateProcess().

I count 17 instances (excluding run_command). At least fetch-pack
is not trivial (the sideband code. Could be done in a  thread, which
is not portable just as well).

> But removing fork isn't worth doing until someone is seriously
> trying to port Git onto Windows without Cygwin.  The current code
> works on sane OSes and isn't broken, so why fix it?

Right.