From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 17 Aug 2006 11:59:02 GMT
Subject: Re: [PATCH] introduce inline is_same_sha1
Message-ID: <81b0412b0608170459if099fcane9d9e91a3fdac9e6@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.63.0608161721020.11465@chino.corp.google.com>

On 8/17/06, David Rientjes <rientjes@google.com> wrote:
> Introduces global inline:
>         is_same_sha1(const unsigned char *sha1,
>                      const unsigned char *sha2);

It is longer and negates all (like in "lots") previous callsites of memcmp.
Are sure you didn't do a trivial typo somewhere?

Why not just sha1cmp? And if you're aiming at hash-type independence,
why not hashcmp?