From: Alex Riesen <raa.lkml@gmail.com>
Date: Fri, 30 Jun 2006 08:21:15 GMT
Subject: Re: [PATCH 2/4] make filepairs detachable
Message-ID: <81b0412b0606300121q4148dfb0qb5915bd029d72f44@mail.gmail.com>
In-Reply-To: <7v7j2zkrod.fsf@assigned-by-dhcp.cox.net>

On 6/30/06, Junio C Hamano <junkio@cox.net> wrote:
>
> > BTW, is there any chance we get the struct diff_filepair's
> > double-linked? They don't seem to be sorted. Will increase
> > the memory footprint, though.
>
> You do not necessarily have to do things in place.  In fact, all
> of the standard diffcore transformers create a new queue, read
> from the old queue and place the filtered or munged result in
> the new queue, swap the global queued_diff variable to point at
> the new one and discard the old queue.
>
> See diff.c::diffcore_apply_filter() for the simplest example.
>

I see. Looks dangerous outside of diff.c though.