From: Alex Riesen <raa.lkml@gmail.com>
Date: Mon, 23 Jan 2006 13:07:18 GMT
Subject: Re: [PATCH] DT_UNKNOWN: do not fully trust existence of DT_UNKNOWN
Message-ID: <81b0412b0601230507n34311c14l5f1c14528f90ec14@mail.gmail.com>
In-Reply-To: <7vpsmmt32x.fsf@assigned-by-dhcp.cox.net>

On 1/21/06, Junio C Hamano <junkio@cox.net> wrote:
> Alex Riesen <raa.lkml@gmail.com> writes:
>
> >> +#undef DT_UNKNOWN
> >> +#undef DT_DIR
> >> +#undef DT_REG
> >> +#undef DT_LNK
> >
> > yes, of course
>
> That is technically correct but I suspect it would not matter in
> practice.  The only thing you are avoiding is four compiler
> warnings when compiling for Cygwin of this week (I heard this is
> already fixed in Cygwin CVS).  On older Cygwin you simply would
> not use NO_D_TYPE_IN_DIRENT, since d_type worked before.  No?

Yes :)