From: Alfred Perlstein Date: Mon, 13 Jun 2016 12:52:12 GMT Subject: Re: [PATCH] Document the 'svn propset' command. Message-ID: <81a197e2-7e0e-176a-c934-0e5f95cfda83@freebsd.org> In-Reply-To: Thank you Pranit. I thought that "signed off by" is used once someone approved my patch as opposed to when it's in "proposal" stage. This was my first email with a patch for this issue, who should/could I have used for "signoff"? -Alfred On 6/12/16 11:59 PM, Pranit Bauva wrote: > Hey Alfred, > > On Mon, Jun 13, 2016 at 12:45 AM, Alfred Perlstein wrote: >> Junio + all, >> >> A week ago I was requested to provide documentation for the >> 'svn propset' command. I have attached a diff off of the >> 'maint' branch for this, however it seems to apply cleanly >> to 'master' as well. >> >> Thank you for your patience. >> >> This is also available on my github here: >> https://github.com/splbio/git/tree/document_propset > I am not particularly sure whether the above could form a good commit > message. I think you wanted to include this as a comment. git-am picks > up these patches. The title commit is taken from the subject stripping > the '[PATCH]'. Then the body before '---' is taken as the rest of the > commit message. Then the diff is applied. To include comments add them > after ---. Also please have a look at Documentation/SubmittingPatches. > Also missing signoff. For the patch to actually be accept you need to > follow those instructions. Thanks for contributing. > >> --- >> Documentation/git-svn.txt | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt >> index fb23a98..e104824 100644 >> --- a/Documentation/git-svn.txt >> +++ b/Documentation/git-svn.txt >> @@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log' >> Gets the Subversion property given as the first argument, for a >> file. A specific revision can be specified with -r/--revision. >> >> +'propset':: >> + Sets the Subversion property given as the first argument, to the >> + value given as the second argument for the file given as the >> + third argument. >> ++ >> +Example: >> ++ >> +------------------------------------------------------------------------ >> +git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile >> +------------------------------------------------------------------------ >> ++ >> +This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file >> +'devel/py-tipper/Makefile'. >> + >> 'show-externals':: >> Shows the Subversion externals. Use -r/--revision to specify a >> specific revision. > Regards, > Pranit Bauva >