From: dhruva <dhruva@ymail.com>
Date: Fri, 19 Sep 2008 02:56:00 GMT
Subject: Re: [PATCH] Optional shrinking of RCS keywords in git-p4
Message-ID: <816161.55725.qm@web95003.mail.in2.yahoo.com>

Hello,



----- Original Message ----
> From: dhruva <dhruva@ymail.com>
> To: Jing Xue <jingxue@digizenstudio.com>; David Brown <git@davidb.org>
> > 
> > How about collapsing the keywords in the _p4_ version after "p4 edit"
> > but before applying the patch, and just "p4 submit" the collapsed
> > version if patching succeeds? As pointed out earlier in this thread, p4
> > submit doesn't care about whether keywords are expanded or not anyway.
> 
> That is feasible but would require more changes. I still feel having an option 
> to disable the keyword from collapsing is a move forward followed by your 
> suggestion as a bug fix to fix the issue with 'p4 submit' when rcs keywords are 
> collapsed. Would that be an acceptable approach?
> 


If there are no more suggestions or objections, could we go ahead with patch? Personally, I would love to start seeing my small contributions getting into mainline and hence the shameless eagerness :)
-dhruva


      Add more friends to your messenger and enjoy! Go to http://in.messenger.yahoo.com/invite/