From: Jonathan del Strother <jon.delstrother@bestbefore.tv>
Date: Thu, 11 Oct 2007 07:30:16 GMT
Subject: Re: [PATCH] Fixing path quoting issues
Message-ID: <81156EED-7AC0-4C8B-98B1-8338262459A6@bestbefore.tv>
In-Reply-To: <470DCC76.7070809@viscovery.net>


On 11 Oct 2007, at 08:10, Johannes Sixt wrote:

> David Kastrup schrieb:
>> Johannes Sixt <j.sixt@viscovery.net> writes:
>>> IMHO, it's not too much of a burden for developers to require "sane"
>>> build directory paths.
>> For a normal user, the only writable directories might be of the
>> "C:\Programs and Data\User settings\Karl"
>> variety.
>
> I whole-heartedly agree about the part of the patch that fixes git- 
> rebase.sh. This should be a separate patch.
>
> But the reset of the patch is about running the test suite, and it  
> is much more difficult to fix because of the 'eval' that is going  
> on. And, yes, I do think that we can expect that contributors,  
> including this handful of people on Windows, have a "sane" build  
> directory.

How are you going to test that git works on paths with spaces if the  
test suite doesn't run there?