From: Phillip Wood Date: Fri, 18 Mar 2022 11:08:31 GMT Subject: Re: [PATCH v3 2/5] reset: introduce --[no-]refresh option to --mixed Message-ID: <80a5f411-2ddb-177f-4139-1dfff436deda@gmail.com> In-Reply-To: <101cee42dd6d5a4e5f12da647eafab9334d69a2d.1647308982.git.gitgitgadget@gmail.com> Hi Victoria [replying to v3 rather than v4 as gmail still hasn't delivered that version] On 15/03/2022 01:49, Victoria Dye via GitGitGadget wrote: > + /* > + * If refresh is completely unspecified (either by config or by command > + * line option), decide based on 'quiet'. > + */ > + if (refresh < 0) > + refresh = !quiet; This keeps the current behavior of not refreshing when --quiet is given. I wonder how disruptive it would be to take the opportunity to get rid of that hack and go back the the original behavior of refreshing when --quiet is given. There are a couple of assumptions that make me think it might be acceptable 1 - anyone using a sparse index wont notice as refreshing the index should be fast for them 2 - the large repositories that are affected exist in managed environments where an admin who reads the release notes could set reset.refresh in a central config so individual users are not inconvenienced. Best Wishes Phillip