From: Junio C Hamano Date: Mon, 05 Dec 2005 21:47:47 GMT Subject: Re: [PATCH] config.c: remove unnecessary header in minimum configuration file. Message-ID: <7vzmnf9px8.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: > However, reading the code I am not satisfied. If there is no template for > the config file, it does not test the filemode at all. I have a feeling that you have not tried the code you are arguing against. It always creates the config file because it needs to record the repository format version (among other things), so the config file exists even if you do not have templates. Even if you do not have a valid template directory that is supposed to work, but obviously you have not tried it ;-). Now, it is arguable that the current format version being 0, and not having the format version is equivalent to having 0 as the format version, it is not necessary to create an empty configuration file at this moment, but by making sure we record the format version the tool that created the repository supports now in the version 0, we do not have to risk forgetting to add that logic later when we _do_ need to write something non-zero.