From: Junio C Hamano Date: Mon, 17 Apr 2006 21:42:35 GMT Subject: Re: [PATCH 7/7] cleanups: remove unused variable from exec_cmd.c Message-ID: <7vzmijkhf8.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20060417151448.3130F19B914@sergelap.hallyn.com> "Serge E. Hallyn" writes: > Not sure whether it should be removed, or whether > execv_git_cmd() should return it rather than -1 at bottom. The only one that does not just die() upon failure is git.c but it checks errno itself, so I think removal is fine.