From: Junio C Hamano Date: Mon, 08 May 2006 20:54:50 GMT Subject: Re: (patch) calloc->xcalloc in read-cache.c Message-ID: <7vzmhsdyp1.fsf@assigned-by-dhcp.cox.net> In-Reply-To: "Yakov Lerner" writes: > --- read-cache.c.000 2006-05-08 15:13:57.000000000 +0000 > +++ read-cache.c 2006-05-08 15:15:35.000000000 +0000 > @@ -557,7 +557,7 @@ > > active_nr = ntohl(hdr->hdr_entries); > active_alloc = alloc_nr(active_nr); > - active_cache = calloc(active_alloc, sizeof(struct cache_entry *)); > + active_cache = xcalloc(active_alloc, sizeof(struct cache_entry *)); > > offset = sizeof(*hdr); > for (i = 0; i < active_nr; i++) { > > Yakov While I do not mind hand generated patch, your mailer setting seems to be seriously broken. Mind checking Documentation/SubmittingPatches and try again?