From: Junio C Hamano Date: Sun, 25 Jun 2006 01:20:46 GMT Subject: Re: [PATCH] Introduce Git.pm (v3) Message-ID: <7vzmg2rpxt.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: > My original idea: on a machine where you have no accurate diff, you at > least want to pass the tests, and you want to ensure you can apply a diff > you generated on that machine. I remember that, but I think recently we converted t4100 and t4101 to use pregenerated test vectors so it might not be an issue anymore? > This patch is just compile tested, but obviously correct Looks sane, thanks. I would maybe rename the option to --inaccurate-eof and default it to off (i.e. no --accurate-eof option). After all we are not talking about arbitrary inaccuracy but the particular botch of not having "\No newline at the end of file."