From: Junio C Hamano <junkio@cox.net>
Date: Thu, 24 Aug 2006 18:45:41 GMT
Subject: Re: [PATCH/RFC 1/x] gitweb: Use git-diff-tree patch output for commitdiff
Message-ID: <7vzmdu7z1m.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <eck1em$p8b$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

> Junio C Hamano wrote:
>
>> Jakub Narebski <jnareb@gmail.com> writes:
>> 
>>> Converting "blobdiff" and "blobdiff_plain" format would be much easier
>>> if git-diff-tree and friends had -L <label>/--label=<label> option,
>>> like GNU diff has.
>> 
>> I am not sure how that would be useful, given that you would
>> disect the header line-by-line to colorize anyway.
>
> gitweb could output patch directly (slurp-print) in blobdiff_plain,
> if there were -L <label>/--label=<label> option to git-diff. As it is now
> git_blobdiff_plain (or git_blobdiff('plain')) would have to process diff
> header, replacing hashes by file names.

I do not think gitweb does diff between two arbitrary blobs; in
other words, you only need "diff-tree treeA treeB -- path".

I think feeding object names _is_ what's causing you trouble.