From: Junio C Hamano <junkio@cox.net>
Date: Sun, 17 Sep 2006 09:00:16 GMT
Subject: Re: [PATCH] gitweb: fix uninitialized variable warning.
Message-ID: <7vzmcy6f6n.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060916210902.GW17042@admingilde.org>

Martin Waitz <tali@admingilde.org> writes:

> @@ -2436,7 +2432,11 @@ sub git_blob {
>  		} else {
>  			die_error(undef, "No file name defined");
>  		}
> +	} elsif ($hash =~ m/^[0-9a-fA-F]{40}$/) {
> +		# blobs defined by non-textual hash id's can be cached
> +		$expires = "+1d";
>  	}
> +
>  	my $have_blame = gitweb_check_feature('blame');
>  	open my $fd, "-|", git_cmd(), "cat-file", "blob", $hash
>  		or die_error(undef, "Couldn't cat $file_name, $hash");

Will apply, but you seem to be out of sync.