From: Junio C Hamano <junkio@cox.net>
Date: Tue, 03 Apr 2007 20:40:35 GMT
Subject: Re: git-index-pack really does suck..
Message-ID: <7vzm5pur7g.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <alpine.LFD.0.98.0704031625050.28181@xanadu.home>

[sorry, sent a message without finishing]

Nicolas Pitre <nico@cam.org> writes:

> Maybe we shouldn't run index-pack on packs for which we _already_ have 
> an index for which is the most likely reason for the collision check to 
> trigger in the first place.
>
> This is in the same category as trying to run unpack-objects on a pack 
> within a repository and wondering why it doesn't work.
> ...
> I'm of the opinion that this patch is unnecessary.  It only helps in 
> bogus workflows to start with, and it makes the default behavior unsafe 
> (unsafe from a paranoid pov, but still).  And in the _normal_ workflow 
> it should never trigger.

Hmmmm.  You may have a point.

So maybe we should retitle this thread from "git-index-pack
really does suck.." to "I used git-index-pack in a stupid way"?