From: Junio C Hamano <junkio@cox.net>
Date: Sun, 29 Apr 2007 05:45:39 GMT
Subject: Re: [PATCH 3/5] Use remote functions in git-push
Message-ID: <7vzm4rg2d8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0704281304190.28708@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

> diff --git a/builtin-push.c b/builtin-push.c
> index cb78401..2e944cd 100644
> --- a/builtin-push.c
> +++ b/builtin-push.c
> @@ -5,6 +5,7 @@
>  #include "refs.h"
>  #include "run-command.h"
>  #include "builtin.h"
> +#include "remote.h"

As I am rejecting the initial round of [PATCH 2/5], I only gave
a cursory look at this one, but it seems straightforward code
shuffling and nothing controversial.

I however would have liked a patch that moves bulk of remote
parsing code from builtin-push.c to remote.c without adding
anything that builtin-push.c did not have (i.e. fetch refspecs
handling).  That is, half of [PATCH 2/5] and this patch should
have been a single patch that says "this moves code from
builtin-push.c to remote.c, while abstracting out the static
variables into struct remote, without doing anything else".

Then later you enhance the remote.c interface to deal with fetch
refspecs and stuff in separate patches.

>  
>  #define MAX_URI (16)

I do not think you need this anymore...