From: Junio C Hamano Date: Fri, 01 Jun 2007 03:54:14 GMT Subject: Re: [PATCH] Add basic test-script for git-submodule Message-ID: <7vzm3kz5w9.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <8c5c35580705292348q74281f7eu15b3b61f45b2c6f5@mail.gmail.com> "Lars Hjemli" writes: > Would you prefer a patch on top of this version of the test-script or > on top of the later patch which uses .git/config to store submodule > url? As you said you will be redoing submodule + .git/config stuff in your other message, I would expect a replacement (i.e. not on top of this) patch for tests to check the existing submodule features. If you want to finish the submodule + .git/config one first and then test script on top to test both existing featues and submodule + .git/config features, that is fine as well. Your choice. One important point is to treat the test-script take #1 as "already rejected", and not basing further patches on it.