From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 11 Nov 2007 08:23:46 GMT
Subject: Re: [PATCH 0/3] Adding colors to git-add--interactive
Message-ID: <7vzlxlgpgt.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071111075446.GA26985@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> -	system(qw(git diff-index -p --cached HEAD --),
>> -	       map { $_->{VALUE} } @them);
>> +	system(qw(git diff -p --cached HEAD --), map { $_->{VALUE} } @them);
>
> Now this was a surprise after reading the commit message.

This hunk makes the "show diff" subcommand honor user's external
diff viewer if specified, which is a good change.  But it does
not belong to the "colored add -i" series.

I mildly suspect that this change might have been my fault, but
I think it should be treated in an independent patch anyway.