From: Junio C Hamano Date: Thu, 22 May 2008 17:49:09 GMT Subject: Re: [PATCH] Fix t3701 if core.filemode disabled Message-ID: <7vzlqiut4a.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080522132042.GF3206@steel.home> Alex Riesen writes: > Jeff King, Wed, May 21, 2008 16:36:07 +0200: >> 2. It's a little hard to see which tests are affected. I would have done >> something more like: >> >> if test "$(git config --bool core.filemode)" = true >> test_filemode= >> else >> test_filemode=: >> fi >> >> $test_filemode test_expect_success ... >> >> But maybe that is just overengineering. > > But a nice one. I like the idea but Junio already did your other > suggestions in master, so I just keep it in mind for the next one If you like that, I think you would like the way t0050 does even better ;-). It is Steffen Prohaska's invention, IIRC.