From: Junio C Hamano Date: Thu, 16 Oct 2008 05:23:20 GMT Subject: Re: [PATCH try 2] t1301-shared-repo.sh: don't let a default ACL interfere with the test Message-ID: <7vzll5jepj.fsf@gitster.siamese.dyndns.org> In-Reply-To: <48F5A590.3050905@viscovery.net> Johannes Sixt writes: > Junio C Hamano schrieb: > >> If that is the case what difference does your suggestion of not putting it >> in test-lib.sh make? We discourage users from playing ACL games, and we >> protect ourselves from such by making sure the trash directory used for >> running tests are not contaminated with ACL. Wouldn't it make more sense >> to do so for all the tests, so that future test writers do not have to >> worry about it? > > We have to decide case by case. In the case of shared directories it makes > sense to suggest "do not play ACL games". In other cases, however, this > suggestion could not work out that well, and a workaround in the code is > the better solutions. But we do not know what those other cases are, and > the test suite may be a tool to uncover them. Although I am not particularly interested in hypothetical case that does not have concrete examples, I do not care deeply enough either. So let's take this patch (with updated/corrected log message) that minimally covers the parts that can be broken by ACL games.