From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Feb 2009 03:23:44 GMT
Subject: Re: [PATCH 10/13] remote.c: make match_refs() copy src ref before assigning to peer_ref
Message-ID: <7vzlgcmsan.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <76718490902231906n620aac40x5c0663fd420c7f39@mail.gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> This issue existed before, but the other callers of match_heads() only
> call it once before the process terminates, and don't bother to free
> what it returns. So those callers didn't notice. This topic introduces
> the first caller that calls match_heads() repeatedly, so it frees the
> returned ref list after it has copied out what it needs.
>
> The change is independent and can be moved anywhere in the series, or
> even introduced as a patch independent of the series itself.

Thanks for explanation.

If I am reading the above correctly, a sequence that does not have 10/13
before the patch that makes match_heads() called repeatedly would break
bisection, so it cannot be "can be moved anywhere".

And it sounds like keeping this as a separate patch would make more
sense.  Your proposed commit log message for the patch would contain the
first paragraph I quoted above, I'd think.