From: Junio C Hamano Date: Sat, 07 Mar 2009 20:00:09 GMT Subject: Re: [PATCH] Brown paper bag fix for MinGW 64-bit stat Message-ID: <7vzlfxnlx2.fsf@gitster.siamese.dyndns.org> In-Reply-To: <03fcab37c921f5728deded11c07bdf32a263b79b.1236436185u.git.johannes.schindelin@gmx.de> Johannes Schindelin writes: > When overriding the identifier "stat" so that "struct stat" will be > substituted with "struct _stati64" everywhere, I tried to fix the calls > to the _function_ stat(), too, but I forgot to change the earlier > attempt "stat64" to "_stati64" there. > > So, the stat() calls were overridden by calls to _stati64() instead. > > Unfortunately, there is a function _stati64() so that I missed that > calls to stat() were not actually overridden by calls to mingw_lstat(), > but t4200-rerere.sh showed the error. > > Signed-off-by: Johannes Schindelin Since this is a fix-up to a new on 'master', I've applied the patch myself, but how would we want to handle MinGW related patches in general? My preference is to have somebody I can rely on receiving Acked forwards from (or pulling from).