From: Junio C Hamano Date: Sun, 24 May 2009 20:43:39 GMT Subject: Re: [PATCH 06/18] Don't expect verify_pack() callers to set pack_size Message-ID: <7vzld2teo4.fsf@alter.siamese.dyndns.org> In-Reply-To: <20090524221947.c83d6aba.rctay89@gmail.com> Tay Ray Chuan writes: > Since use_pack() will end up populating pack_size if it is not already set, > we can just adapt the code in verify_packfile() such that it doesn't require > pack_size to be set beforehand. > > This allows callers not to have to set pack_size themselves, and we can thus > revert changes from 1c23d794 (Don't die in git-http-fetch when fetching packs). > > Signed-off-by: Mike Hommey > Signed-off-by: Tay Ray Chuan When you forward somebody else's patch, please be careful not to lose the attribution, by having From: Mike Hommey Date: <<>> and an empty line before you start the commit log message.