From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 01 Jul 2009 22:55:19 GMT
Subject: Re: [PATCH 2/6] grep: move context hunk mark handling into show_line()
Message-ID: <7vzlbodne0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4A4BDCFE.3050808@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Move last_shown into struct grep_opt, to make it available in
> show_line(), and then make the function handle the printing of hunk
> marks for context lines in a central place.

Makes sense.  But now "are we showing from a separate block of text" check
is in show_line() and relieves the caller of show_line() from doing so,...

>  		else if (last_hit &&
>  			 lno <= last_hit + opt->post_context) {
>  			/* If the last hit is within the post context,
>  			 * we need to show this line.
>  			 */
> -			if (last_shown && lno != last_shown + 1)
> -				fputs(hunk_mark, stdout);
>  			show_line(opt, bol, eol, name, lno, '-');
> -			last_shown = lno;

... the comment in this context should go, no?