From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 20 Oct 2009 06:30:56 GMT
Subject: Re: [PATCH] am: allow some defaults to be specified via git-config
Message-ID: <7vzl7mshjz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4ADD241F.9060004@catalyst.net.nz>

Sam Vilain <sam.vilain@catalyst.net.nz> writes:

> Wesley J. Landaker wrote:
>> On Thursday 15 October 2009 17:50:27 Sam Vilain wrote:
>>> +am.*::
>>> +	Specify defaults for linkgit:git-am[1].  Currently, the three
>>> +	boolean options, 'sign', 'utf8' and 'keep' may be specified.
>>> +
>> 
>> The 'git am' option is 'signoff', not 'sign'. Shouldn't the command option 
>> and config option names match?
>
> Thanks for pointing that out.  Yes, it should be.

Wouldn't this patch make issues like $gmane/130744 even worse, unless you
add some disabling code to rebase?