From: Junio C Hamano Date: Tue, 16 Mar 2010 07:25:07 GMT Subject: Re: [patch 13/15] no-socklen_t.patch Message-ID: <7vzl28lodo.fsf@alter.siamese.dyndns.org> In-Reply-To: <20100316054403.034575000@mlists.thewrittenword.com> "Gary V. Vaughan" writes: > +ifneq (socklen_t,$(SOCKLEN_T)) > + BASIC_CFLAGS += -Dsocklen_t=$(SOCKLEN_T) > +endif This looks like making use of configure mandatory to me? Could you do this patch without doing so? The same comment applies to [15/15]. Thanks.