From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Mar 2011 05:38:54 GMT
Subject: Re: [PATCH nd/struct-pathspec] declare 1-bit bitfields to be unsigned
Message-ID: <7vzkov8w0h.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110316034232.GA26027@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

> As "gcc -pedantic" notices, a two's complement 1-bit signed integer
> cannot represent the value '1'.

Thanks; this is one of the things I try to be reasonably careful about
when I eyeball patches, but apparently I didn't spot it.

Perhaps I should start compiling with -Woverflow.