From: Junio C Hamano Date: Mon, 21 Mar 2011 19:29:13 GMT Subject: Re: [PATCHv2 2/2] Fix sparse warnings Message-ID: <7vzkoop912.fsf@alter.siamese.dyndns.org> In-Reply-To: <1300730506-6582-1-git-send-email-bebarino@gmail.com> Stephen Boyd writes: > Fix warnings from 'make check'. > ... > Signed-off-by: Stephen Boyd > --- > > On 03/21/11 09:15, Junio C Hamano wrote: >> >> Yuck. Could you summarize the errors by grouping them by type or >> something in the log? One mega-patch we can swallow, but the log is >> unreadble. > > Sure. Both comments addressed. Still yeek... What I meant was more like at the minimum: - "warning: symbol 'x' was not declared. Should it be static?" builtin/clone.c:365, builtin/fetch-pack.c:797, ... - "error: symbol 'x' redeclared with different type' parse-options.c:564, ... or much more preferably: - These files use symbols without declaring, because they do not include "builtin.h": builtin/clone.c (cmd_clone), builtin/fetch-pack.c (cmd_fetch_pack), ... - These files define extern symbols without declaring, and they can be file scope static: builtin/fmt-merge-msg.c (init_src_data), ... - These callsites pass literal integer 0 where they mean to pass a NULL pointer: builtin/notes.c (resolve_ref), ... The patch text itself look more or less Ok, but I see you have builtin.h not as the first include in builtin/pack-redundant.c. Thanks.