From: Junio C Hamano Date: Thu, 28 Apr 2011 21:05:09 GMT Subject: Re: [PATCH] Honor sysconfdir when set as an configure option Message-ID: <7vzkna2ika.fsf@alter.siamese.dyndns.org> In-Reply-To: <20110428200113.GF4833@camk.edu.pl> Kacper Kornet writes: > ./configure can be run with option --sysconfdir=... > and Makefile should respect that choice. Thanks. That statement is not wrong per-se, but your patch will result in git_etcdir always set to the same as $(sysconfdir) that is an absolute path, which in turn would mean that the build product with prefix set to something other than /usr won't relocate well, no? Not that I personally deeply care about it, but I understand msysgit folks spent considerable amount of brainpower to come up with the arrangement, so they may want to have a say on this patch. "git shortlog -n --no-merges --grep=msys --grep=Win -- Makefile" tells me that Steffen Prohaska and J6t are the people to whom I need to Cc: this. > ifeq ($(prefix),/usr) > -sysconfdir = /etc > -git_etcdir = /etc > +sysconfdir ?= /etc > +git_etcdir ?= /etc > else > -sysconfdir = $(prefix)/etc > -git_etcdir = etc > +sysconfdir ?= $(prefix)/etc > +git_etcdir ?= etc > endif > > ifdef CHECK_HEADER_DEPENDENCIES > diff --git a/config.mak.in b/config.mak.in > index e378534..ac5912d 100644 > --- a/config.mak.in > +++ b/config.mak.in > @@ -15,6 +15,8 @@ TCLTK_PATH = @TCLTK_PATH@ > prefix = @prefix@ > exec_prefix = @exec_prefix@ > bindir = @bindir@ > +sysconfdir = @sysconfdir@ > +git_etcdir = @sysconfdir@ > gitexecdir = @libexecdir@/git-core > datarootdir = @datarootdir@ > template_dir = @datadir@/git-core/templates > -- > 1.7.5