From: Junio C Hamano Date: Wed, 06 Jul 2011 21:20:45 GMT Subject: Re: [PATCH 07/14] revert: Introduce struct to keep command-line options Message-ID: <7vzkkrjec2.fsf@alter.siamese.dyndns.org> In-Reply-To: <1309938868-2028-8-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra writes: > The variable "me" is left as a file-scope static variable because it > is not an independent option. "me" is simply a string that needs to > be inferred from the "action" option, and is kept global to save each > function the trouble of determining it independently. Would it make more sense to remove the variable, pass "action" around where only "me" is passed around right now, and introduce a function "static const char *action_name()" to help places that wants textual command name for display purposes?