From: Junio C Hamano Date: Tue, 14 Feb 2012 19:06:24 GMT Subject: Re: [PATCH 2/5] do not override receive-pack errors Message-ID: <7vzkcl6xqn.fsf@alter.siamese.dyndns.org> In-Reply-To: <20120214083324.GA1762@ecki> Clemens Buchacher writes: > Yes, it really is. For example, in t5504 rev-list --verify-objects (it > was turned on for me if called from there) detects the corrupt object. > But the error string is later overwritten with the return value of > update, which is NULL in this case. > ... > Actually, check_alias_update searches for aliases of cmd in ref_list, > which is a list of refs from all commands, irrespective of their error > status. So this change is correct. Ok, thanks for clarificatin on both counts.