From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 07 Mar 2012 21:59:46 GMT
Subject: Re: [PATCH] fmt-merge-msg: show those involved in a merged series
Message-ID: <7vzkbskr71.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F57D18B.5090506@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Am 05.03.2012 22:34, schrieb Junio C Hamano:
>
>> +#define util_as_int(elem) ((intptr_t)((elem)->util))
>
> Something that actually returns an int would fit the name better. ;)

The particular type would not matter to the callers of the helper
macro, would it?

>> +static int committer_is_me(const char *name)
>> +{
>> +	int namelen = strlen(name);
>> +	const char *me = git_committer_info(IDENT_NO_DATE);
>> +	return (me && !memcmp(me, name, namelen) &&
>> +		!memcmp(me + namelen, " <", 2));
>> +}
>
> This looks scary due to the missing length check of me before the
> memcmp() call, but is actually safe because git_committer_info()
> returns a pointer to a static buffer that is just as long as name can
> possibly be.  Still, perhaps this is nicer instead:
>
> 	const char *me = git_committer_info(IDENT_NO_DATE);
> 	const char *rest = skip_prefix(me, name);
> 	return rest && skip_prefix(rest, " <");

Probably.  Let me fix it up.

Thanks.